Comments on: Go Sub, to go? http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/ Fri, 21 Nov 2008 22:03:08 +0000 http://wordpress.org/?v=2.0.1 by: ross http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-72 Mon, 27 Mar 2006 09:49:43 +0000 http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-72 thanks John, Sorry that the code is not very well displayed, when time permits i will look into it ;-) thanks John, Sorry that the code is not very well displayed, when time permits i will look into it ;-)

]]> by: John Skewes http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-68 Fri, 24 Mar 2006 04:49:37 +0000 http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-68 Hi Ross, Yes, not to mention the static vars... Gosub and Return was used in a lot of earlier programming languages, notably BASIC (<em>the grandfather of VBA</em>). You can have as many Gosub/Returns as you like in a procedure but its use has largely declined due to the propensity for novice programmers to use it in a loose unstructered manner, with GoSubs and Returns popping up everywhere in the main body of code. It then becomes difficult to follow the flow of the code. Never-the-less, it can be handy occasionally <strong>as long as it's kept structured and not 'overdone'</strong>. I've updated the example on my site to show the difference, here it is (<em>I don't know if the code tags will show properly here</em>) --------------------------------------------------------------------------------- A simple example use of Gosub and Return... [VBA]Sub CopyRows_UseGosub() Dim Cell As Range, TargetSheet As String With Sheets("Sheet1") For Each Cell In .Range("A2", .Range("A" &#38; Rows.Count).End(xlUp)) Select Case Cell.Offset(0, 4) Case "Match" TargetSheet = "Sheet2": GoSub DoCopy Case "No Match" TargetSheet = "Sheet3": GoSub DoCopy Case "Part Match" TargetSheet = "Sheet4": GoSub DoCopy Case "Negative Match" TargetSheet = "Sheet5": GoSub DoCopy Case Else TargetSheet = "Sheet6": GoSub DoCopy End Select Next Exit Sub DoCopy: .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets(TargetSheet).Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) Return End With End Sub[/VBA] As a comparison, the alternative code below to accomplish exactly the same task is 'wordier', more obscure for a coder to 'read', and it's difficult to ascertain the differences for each case (<em>the only differences being the sheets name</em> :)) [VBA]Sub CopyRows_NoGosub() Dim Cell As Range With Sheets("Sheet1") For Each Cell In .Range("A2", .Range("A" &#38; Rows.Count).End(xlUp)) Select Case Cell.Offset(0, 4) Case "Match" .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets("Sheet2").Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) Case "No Match" .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets("Sheet3").Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) Case "Part Match" .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets("Sheet4").Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) Case "Negative Match" .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets("Sheet5").Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) Case Else .Range(Cell.Address, Cell.Offset(0, 2)).Copy _ Sheets("Sheet6").Range("A" &#38; Rows.Count) _ .End(xlUp).Offset(1, 0) End Select Next End With End Sub[/VBA] Hi Ross,

Yes, not to mention the static vars... Gosub and Return was used in a lot of earlier programming languages, notably BASIC (the grandfather of VBA).

You can have as many Gosub/Returns as you like in a procedure but its use has largely declined due to the propensity for novice programmers to use it in a loose unstructered manner, with GoSubs and Returns popping up everywhere in the main body of code. It then becomes difficult to follow the flow of the code.

Never-the-less, it can be handy occasionally as long as it's kept structured and not 'overdone'. I've updated the example on my site to show the difference, here it is (I don't know if the code tags will show properly here)

---------------------------------------------------------------------------------

A simple example use of Gosub and Return...

Sub CopyRows_UseGosub()

      Dim Cell As Range, TargetSheet As String

      With Sheets("Sheet1")
            For Each Cell In .Range("A2", .Range("A" &amp; Rows.Count).End(xlUp))
                  Select Case Cell.Offset(0, 4)
                  Case "Match"
                        TargetSheet = "Sheet2": GoSub DoCopy
                  Case "No Match"
                        TargetSheet = "Sheet3": GoSub DoCopy
                  Case "Part Match"
                        TargetSheet = "Sheet4": GoSub DoCopy
                  Case "Negative Match"
                        TargetSheet = "Sheet5": GoSub DoCopy
                  Case Else
                        TargetSheet = "Sheet6": GoSub DoCopy
                  End Select
            Next
            Exit Sub

DoCopy:
            .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                        Sheets(TargetSheet).Range("A" &amp; Rows.Count) _
                        .End(xlUp).Offset(1, 0)
            Return

      End With
End Sub

As a comparison, the alternative code below to accomplish exactly the same task is 'wordier', more obscure for a coder to 'read', and it's difficult to ascertain the differences for each case (the only differences being the sheets name :))

Sub CopyRows_NoGosub()

      Dim Cell As Range

      With Sheets("Sheet1")
            For Each Cell In .Range("A2", .Range("A" &amp; Rows.Count).End(xlUp))
                  Select Case Cell.Offset(0, 4)
                  Case "Match"
                        .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                                    Sheets("Sheet2").Range("A" &amp; Rows.Count) _
                                    .End(xlUp).Offset(1, 0)
                  Case "No Match"
                        .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                                    Sheets("Sheet3").Range("A" &amp; Rows.Count) _
                                    .End(xlUp).Offset(1, 0)
                  Case "Part Match"
                        .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                                    Sheets("Sheet4").Range("A" &amp; Rows.Count) _
                                    .End(xlUp).Offset(1, 0)
                  Case "Negative Match"
                        .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                                    Sheets("Sheet5").Range("A" &amp; Rows.Count) _
                                    .End(xlUp).Offset(1, 0)
                  Case Else
                        .Range(Cell.Address, Cell.Offset(0, 2)).Copy _
                                    Sheets("Sheet6").Range("A" &amp; Rows.Count) _
                                    .End(xlUp).Offset(1, 0)
                  End Select
            Next
      End With
     
End Sub

]]> by: ross http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-65 Tue, 21 Mar 2006 11:29:17 +0000 http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-65 Not to mention the static var dec too John - it's a stange one, but it guess it just another tool like toy say. Not to mention the static var dec too John - it's a stange one, but it guess it just another tool like toy say.

]]> by: John Skewes http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-62 Tue, 21 Mar 2006 03:07:16 +0000 http://www.blog.methodsinexcel.co.uk/2006/02/15/go-sub-to-go/#comment-62 Hi Ross, Yes, I usually would do the same, but it's useful when you may have (<em>say</em>) lots of variables that you don't want to declare as public (<em>but then a function would probably be the way to go</em>) anyway, it's another choice that's always available in our bag of tricks. Regards, John :) Hi Ross,

Yes, I usually would do the same, but it's useful when you may have (say) lots of variables that you don't want to declare as public (but then a function would probably be the way to go) anyway, it's another choice that's always available in our bag of tricks.

Regards,
John :)

]]>